Re: [PATCH 1/2] perf:tools: avoid to create much more maps for kernelsymbols on ARM

From: Ming Lei
Date: Sun Nov 28 2010 - 23:34:56 EST


2010/11/25 Ming Lei <tom.leiming@xxxxxxxxx>:
> 2010/11/24 Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>:
>> Em Wed, Nov 24, 2010 at 07:35:02PM +0800, tom.leiming@xxxxxxxxx escreveu:
>>> From: Ming Lei <tom.leiming@xxxxxxxxx>
>>
>>> On ARM, module addresss space is ahead of kernel space, so the module
>>> symbols are handled before kernel symbol in dso__split_kallsyms, then
>>> cause one map is created for each kernel symbol.
>>
>>> This patch fixes the issue by restoring to original kernel map in
>>> dso__split_kallsyms() to avoid create unnecessary maps for kernel
>>> symbols when starting to handle kenel symbol maps but after module
>>> symbol maps are handled over.
>>
>> Can you try with the following patch instead?
>
> Fine to me.
>
> Reported-and-tested-by: Ming Lei <tom.leiming@xxxxxxxxx>

Arnaldo, could you queue this one and the patch below

http://marc.info/?l=linux-kernel&m=129068448714210&w=2

into your tree? Without the two, perf tool can't work well on ARM
if there are modules loaded.

thanks,
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/