Re: [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check

[viresh kumar]

On Fri, Nov 26, 2010 at 10:36 PM, Vasiliy Kulikov <segoon@xxxxxxxxxxxx> wrote:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
> ---
> ÂCannot compile this driver, so it is not tested at all.
>
> Âarch/arm/plat-spear/time.c | Â Â4 ++--
> Â1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
> index ab21165..678df18 100644
> --- a/arch/arm/plat-spear/time.c
> +++ b/arch/arm/plat-spear/time.c
> @@ -229,13 +229,13 @@ void __init spear_setup_timer(void)
> Â Â Â Â}
>
> Â Â Â Âgpt_clk = clk_get_sys("gpt0", NULL);
> - Â Â Â if (!gpt_clk) {
> + Â Â Â if (IS_ERR(gpt_clk)) {
> Â Â Â Â Â Â Â Âpr_err("%s:couldn't get clk for gpt\n", __func__);
> Â Â Â Â Â Â Â Âgoto err_iomap;
> Â Â Â Â}
>
> Â Â Â Âpll3_clk = clk_get(NULL, "pll3_48m_clk");
> - Â Â Â if (!pll3_clk) {
> + Â Â Â if (IS_ERR(pll3_clk)) {
> Â Â Â Â Â Â Â Âpr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
> Â Â Â Â Â Â Â Âgoto err_iomap;
> Â Â Â Â}

Compiled & tested.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/