Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS

[Randy Dunlap]

On 11/29/10 15:03, Andrew Morton wrote:
> On Tue, 23 Nov 2010 10:41:30 +0100
> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> 
>> On Tue, 2010-11-23 at 09:17 +0000, Ingo Molnar wrote:
>>
>>> It fails to build on x86 64-bit allmodconfig:
>>
>> Let's not modify them to tristate then, too many ifdefs.
>>
>> johannes
>>
>>
>> Subject: leds: fix up dependencies
>> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>>
>> It's not useful to build LED triggers when
>> there's no LEDs that can be triggered by
>> them. Therefore, fix up the dependencies
>> so that this cannot happen, and fix a few
>> users that select triggers to depend on
>> LEDS_CLASS as well (there is also one user
>> that also selects LEDS_CLASS, which is OK).
> 
> Ingo, Randy: does this work for you?
> 

Yes, it passes all of my saved build failure cases.

Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>


> 
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> It's not useful to build LED triggers when there's no LEDs that can be
> triggered by them.  Therefore, fix up the dependencies so that this cannot
> happen, and fix a few users that select triggers to depend on LEDS_CLASS
> as well (there is also one user that also selects LEDS_CLASS, which is
> OK).
> 
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Arnd Hannemann <arnd@xxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/leds/Kconfig      |   50 +++++++++++++++++++++++++++++-------
>  drivers/macintosh/Kconfig |    1 
>  net/mac80211/Kconfig      |    2 -
>  3 files changed, 43 insertions(+), 10 deletions(-)


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/