Re: [BUGFIX] vmstat: fix dirty threshold ordering

From: Minchan Kim
Date: Mon Nov 29 2010 - 22:55:54 EST


On Mon, Nov 29, 2010 at 7:38 PM, Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:
> The nr_dirty_[background_]threshold fields are misplaced before the
> numa_* fields, and users will read strange values.
>
> This is the right order. Before patch, nr_dirty_background_threshold
> will read as 0 (the value from numa_miss).
>
>        numa_hit 128501
>        numa_miss 0
>        numa_foreign 0
>        numa_interleave 7388
>        numa_local 128501
>        numa_other 0
>        nr_dirty_threshold 144291
>        nr_dirty_background_threshold 72145
>
> Cc: Michael Rubin <mrubin@xxxxxxxxxx>
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/