Re: [PATCH 4/4] input: mt: Add pressure to pointer emulation code

[Dmitry Torokhov]

On Mon, Nov 29, 2010 at 12:20:07PM +0100, Henrik Rydberg wrote:
> >> @@ -124,9 +125,13 @@ void input_mt_report_pointer_emulation(struct input_dev
> *dev)
> 
> >>  	if (oldest) {
> >>  		int x = input_mt_get_value(oldest, ABS_MT_POSITION_X);
> >>  		int y = input_mt_get_value(oldest, ABS_MT_POSITION_Y);
> >> +		int p = input_mt_get_value(oldest, ABS_MT_PRESSURE);
> > 
> > What if device does not report ABS_MT_PRESSURE/ABS_PRESSURE? Do we rely
> > on input core to suppress unsupported events? A comment would be nice...
> 
> 
> Yes, the setup values are the only ones producing output here. How about this
> addition to the function text: "The input core ensures only the KEY and ABS axes
> already setup for this device will produce output."?

Yep, that works.

> 
> > Also, is there a gelper to set up pointer emulation capabilities for MT
> > device?
> 
> 
> This is certainly the plan with time, but currently it seemed best to leave the
> rest of the event setup code untouched.
> 

OK, just throwing ideas around ;)

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/