Re: [PATCH] add netdev led trigger

[Pavel Machek]

Please preserve cc lists.

> > I was hoping you'd comment on the ABI itself, too. It uses 
> > 
> > echo "foo bar baz" > file
> > 
> > to enable/disable specific events to be "displayed". More traditional
> > interface would be 
> > 
> > echo disable > file_foo
> 
> The main arguments for using the single "mode" file are:
> 1. that's how it was implemented for OpenWrt, and there's a fair
>    amount of userland (web admin tools, etc.) that groks it

That's not good reason...

> 2. it's only specifying a set of three possible values -- separate
>    files seem like overkill

Does it? AFAICT it allowed any combination of 3 -- IOW 2^3 values.

Please be consistent with rest of kernel...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/