Re: [PATCH] add netdev led trigger

From: Eric Cooper
Date: Tue Nov 30 2010 - 18:22:21 EST


> Please be consistent with rest of kernel...

There seem to be several ways this is done in existing sysfs drivers,
and most aren't documented yet in Documentation/ABI.

1. "0" and "1"
2. "enable" and "disable"
3. "enabled" and "disabled"
4. "enable" and "disable" when writing, but "enabled" and "disabled"
when read back

Some require trailing "\n", others make it optional.

Which is the One True Way?

--
Eric Cooper e c c @ c m u . e d u
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/