Re: [PATCH -v2 2/3] ACPI, APEI, Add APEI generic error status print support

[huang ying]

On Wed, Dec 1, 2010 at 2:00 AM, Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>> + Â Â for (i = 0; i < strs_size; i++) {
>> + Â Â Â Â Â Â if (!(bits & (1U << i)))
>> + Â Â Â Â Â Â Â Â Â Â continue;
>> + Â Â Â Â Â Â str = strs[i];
>> + Â Â Â Â Â Â if (len && len + strlen(str) + 2 > 80) {
>> + Â Â Â Â Â Â Â Â Â Â printk("\n");
>> + Â Â Â Â Â Â Â Â Â Â len = 0;
>> + Â Â Â Â Â Â }
>> + Â Â Â Â Â Â if (!len)
>> + Â Â Â Â Â Â Â Â Â Â len = pr_pfx(pfx, "%s", str);
>> + Â Â Â Â Â Â else
>> + Â Â Â Â Â Â Â Â Â Â len += printk(", %s", str);
>> + Â Â }
>> + Â Â if (len)
>> + Â Â Â Â Â Â printk("\n");
>
> Does printk() offer any guarantees about getting all the characters
> from a single printk() call out to the console without interleaving
> with messages from printk() calls on other cpus? ÂIf it does, then
> it would be a good idea to sprintf() the parts of this message to
> a buffer and then use one printk() call. ÂI think I read that netconsole
> ends up with one packet on the wire for each call to printk().
>
> Trying to parse output jumbled together from multiple cpus
> doesn't sound like fun.

Yes. Will do that.

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/