Re: [7/8, v6] NUMA Hotplug Emulator: extend memory probe interfaceto support NUMA

[David Rientjes]

On Tue, 30 Nov 2010, shaohui.zheng@xxxxxxxxx wrote:

> From: Shaohui Zheng <shaohui.zheng@xxxxxxxxx>
> 
> Extend memory probe interface to support an extra paramter nid,
> the reserved memory can be added into this node if node exists.
> 
> Add a memory section(128M) to node 3(boots with mem=1024m)
> 
> 	echo 0x40000000,3 > memory/probe
> 
> And more we make it friendly, it is possible to add memory to do
> 
> 	echo 3g > memory/probe
> 	echo 1024m,3 > memory/probe
> 
> It maintains backwards compatibility.
> 
> Another format suggested by Dave Hansen:
> 
> 	echo physical_address=0x40000000 numa_node=3 > memory/probe
> 
> it is more explicit to show meaning of the parameters.
> 

I don't like this interface, I think it would be much better to map the 
memory region to the desired node id prior to using probe as an extention 
to debugfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/