Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

From: Kanigeri, Hari
Date: Wed Dec 01 2010 - 21:27:34 EST


On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote:
> On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha <charu@xxxxxx> wrote:
>> David,
>
>>
>>> +               if (!oh)
>>> +                       goto error;
>>> +
>>> +               data->base = oh->_mpu_rt_va;
>>
>> not required. Make use of platform_get APIs in probe to extract the
>> base, dma and irq info using pdev.
>
> Not sure about using platform_get APIs. I think one has to use
> omap_hwmod_get_mpu_rt_va to get the address, which internally returns
> oh-<_mpu_rt_va.
small correction... omap_device_get_rt_va and not omap_hwmod_get_mpu_rt_va.

Thank you,
Best regards,
Hari Kanigeri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/