Re: [Patch] net: kill an RCU warning in inet_fill_link_af()

[Cong Wang]

On 12/02/10 00:03, Eric Dumazet wrote:
> Le mercredi 01 dÃcembre 2010 Ã 19:14 +0800, Amerigo Wang a Ãcrit :
> > From: WANG Cong<amwang@xxxxxxxxxx>
> >
> > The latest net-next-2.6 triggers an RCU warning during boot,
> > lockdep complains that in inet_fill_link_af() we call rcu_dereference_check()
> > without rcu_read_lock() protection.
> >
> > This patch fixes it by replacing __in_dev_get_rcu() with in_dev_get().
>
> Here is a better version, thanks a lot for your report and initial
> patch.
>
>
> [PATCH net-next-2.6] net: kill an RCU warning in inet_fill_link_af()
>
> commits 9f0f7272 (ipv4: AF_INET link address family) and cf7afbfeb8c
> (rtnl: make link af-specific updates atomic) used incorrect
> __in_dev_get_rcu() in RTNL protected contexts, triggering PROVE_RCU
> warnings.
>
> Switch to __in_dev_get_rtnl(), wich is more appropriate, since we hold
> RTNL.
>
> Based on a report and initial patch from Amerigo Wang.

Alright, thanks for fixing it.

Reviewed-by: WANG Cong <amwang@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/