Re: [PATCH 2/3] RFC4106 AES-GCM Driver Using Intel New Instructions

From: Andrew Morton
Date: Thu Dec 02 2010 - 19:14:40 EST


On Thu, 18 Nov 2010 09:38:50 +0000
"Struk, Tadeusz" <tadeusz.struk@xxxxxxxxx> wrote:

> -----Original Message-----
> > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx]
> > Sent: Thursday, November 18, 2010 9:27 AM
> > To: Andrew Morton
> > Cc: Struk, Tadeusz; linux-kernel@xxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; O Mahony, Aidan; Paoloni, Gabriele; Hoban, Adrian
> > Subject: Re: [PATCH 2/3] RFC4106 AES-GCM Driver Using Intel New Instructions
> >
> > On Wed, Nov 17, 2010 at 05:23:31PM -0800, Andrew Morton wrote:
> > > On Thu, 4 Nov 2010 14:04:05 -0500
> > > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > On Thu, Oct 28, 2010 at 04:19:09PM +0100, tadeusz.struk@xxxxxxxxx wrote:
> > > > > Hi Herbert,
> > > > > We have reworked the assembly to use macros instead of the new aesni instructions.
> > > >
> > > > Both applied. Thanks for your efforts!
> > >
> > > Whatever's in today's linux-next is a big fail with gas-2.16.1.
> > >
> > > Which was entirely predictable! How often has this happened recently??
> > >
> > >
> > > arch/x86/crypto/aesni-intel_asm.S: Assembler messages:
> > > arch/x86/crypto/aesni-intel_asm.S:834: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm13'
> > > arch/x86/crypto/aesni-intel_asm.S:866: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm5'
> > > arch/x86/crypto/aesni-intel_asm.S:866: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm0'
> > > arch/x86/crypto/aesni-intel_asm.S:866: Error: bad expression
> >
> > Sorry, but I no longer have access to a binutils that is older
> > than 2.18 so I never saw this failure.
> >
> > Tadeusz, could you please make an incremental patch that converts
> > all the pshufb instructions to macros?
> >
>
> Will do.
> Tadeusz
>

(top-posting repaired)

(busted attribution/quoting repaired)

Current mainline still has this failure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/