Re: [PATCH] ext4: Set barrier=0 when block device does not advertiseflush support

From: Christoph Hellwig
Date: Fri Dec 03 2010 - 02:10:06 EST


On Thu, Dec 02, 2010 at 04:16:59PM -0800, Darrick J. Wong wrote:
> If the user tries to enable write flushes with "barrier=1" and the underlying
> block device does not support flushes, print a message and set barrier=0.

That doesn't make any sense at all with the ne wFLUSH+FUA code, which is
designed to make the cache flushing entirely transparanent. Basically
with the new code the barrier option should become a no-op and always
enabled.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/