Re: [PATCH 0/4] ath: logging message conversion

From: Luis R. Rodriguez
Date: Tue Dec 07 2010 - 14:26:15 EST


On Tue, Dec 07, 2010 at 11:05:28AM -0800, John W. Linville wrote:
> On Thu, Dec 02, 2010 at 07:12:34PM -0800, Joe Perches wrote:
> > ath_print is misleading as it's only used with CONFIG_ATH_DEBUG.
> >
> > Add and use the more normal <subsystem>_printk and <subsystem>_<level>
> > printk equivalents. (ath_printk and ath_<level>)
> >
> > Fix various defects in the current uses of ath_print formats
> > and arguments: Unnecessary casts, missing newlines, multiple
> > prints, and 1 loop which can exceed array bounds.
> >
> > Bundled and integrated the individual patches into a single patch series.
> >
> > Joe Perches (4):
> > ath: Add and use ath_printk and ath_<level>
> > ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err
> > ath: Convert ath_print to ath_dbg
> > ath: Fix ath_dbg access beyond array bound
>
> Is the Atheros crew happy with this series? They didn't seem to like
> the original patches very much...

Its fine now that Joe has addressed some more important items.
But I'd like for the patches to be applied last of all pending
patches :)

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/