Re: [PATCH] x86: Replace uses of current_cpu_data with this_cpu ops

[Eric Dumazet]

Le mercredi 08 dÃcembre 2010 Ã 09:33 -0600, Christoph Lameter a Ãcrit :
> On Wed, 8 Dec 2010, Eric Dumazet wrote:
> 
> > > In the long run, it might be a good idea to remove cpu_data() macro
> > > too and use per_cpu macro directly.
> > >
> >
> > or introduce this_cpu_has() to remove the adress computation
> >
> > -	if (cpu_has(__this_cpu_ptr(&cpu_info), X86_FEATURE_ARAT)) {
> >
> > +	if (this_cpu_has(X86_FEATURE_ARAT)) {
> >
> 
> The fundamental problem is that bitops require memory addresses which does
> not work with per cpu ops.
> 

Sure, set() or clear() needs the address, but the read doesnt ?

This can be implemented as

  (__this_cpu_read(cpu_info.word[X]) & MASK)

Anyway, even if mapped to cpu_has(__this_cpu_ptr(&cpu_info), XXX), 
it would be cleaner to use this_cpu_has() helper.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/