Re: [1/7,v8] NUMA Hotplug Emulator: documentation

From: Shaohui Zheng
Date: Wed Dec 08 2010 - 20:48:11 EST


On Wed, Dec 08, 2010 at 01:16:10PM -0800, David Rientjes wrote:
> On Wed, 8 Dec 2010, Eric B Munson wrote:
>
> > Shaohui,
> >
> > I was able to online a cpu to node 0 successfully. My problem was that I did
> > not take the cpu offline before I released it. Everything looks to be working
> > for me.
> >
>
> I think it should fail more gracefully than triggering WARN_ON()s because
> of duplicate sysfs dentries though, right?

Yes, we should do more checking on the return value, the duplicate dentries can
be avoided.

Another solution: force user to offline the cpu before we do cpu release.

--
Thanks & Regards,
Shaohui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/