Re: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatcherrors

From: Florian Mickler
Date: Thu Dec 09 2010 - 05:34:24 EST


On Thu, 09 Dec 2010 03:32:28 +0000
Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote:

> On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> > Swap argument order in order to avoid checkpatch treating it as an
> > unary operation, instead of an binary one, and obtain consistency
> > with the 3 other similar assignments in netdev.c (tdlen & rdlen).
> >
> > This patch fixes 3 checkpatch errors.
>
> You have got to be kidding. If the checkpatch warning offends you, fix
> the bug in checkpatch instead of changing perfectly good code.
>
> Ben.

That bug is fixed already:
https://patchwork.kernel.org/patch/299172/

Andrew picked it up.

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/