Re: [PATCH] input: mt: Interface and MT_TOOL documentation updates

From: Ping Cheng
Date: Fri Dec 10 2010 - 14:00:34 EST


On Fri, Dec 10, 2010 at 10:13 AM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
>
>> Can we make MT_TOOL_ENVELOPE cover a bit more cases by:
>>
>> 1. Removing ", and is only used for legacy hardware";
>> 2. Adding "Or the number of contacts inside the bounding rectangle is
>> reported if hardware provides the number but not the real contact
>> positions" to the end of the paragraph.
>
> You might disagree, but "old" is still somewhat apt in this situation.

It's ok if we say the new type was inspired by legacy hardware. But
saying that it "is only used for legacy hardware" closes the door for
future development. That's not what we are trying to do, right?

> How would you suggest we report the number of fingers?

I guess if we want to make it generic, we could have something like
ABS_MT_NUM_CONTACTS to go with MT_TOOL_ENVELOPE. Clients, such as
synaptics touchpads, that only care about the number of contacts
inside the envelope don't need to process the contact positions even
when they are reported. This also resolve the potential that
BTN_TOOL_QUADTAP is not enough to tell us how many contacts are on the
surface.

Maybe we should also tell the clients whether they are going to get
the contact positions or not.

Ping
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/