Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 beforeusing the reset register

From: Matthew Garrett
Date: Sun Dec 12 2010 - 19:21:57 EST

Next message: Andi Kleen: "[PATCH] [54/223] reiserfs: don't acquire lock recursively in reiserfs_acl_chmod"
Previous message: Andi Kleen: "[PATCH] [55/223] staging: rt2870: Add new USB ID for Belkin F6D4050 v1"
In reply to: Zhang Rui: "Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 beforeusing the reset register"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Dec 13, 2010 at 08:16:36AM +0800, Zhang Rui wrote:
> On Sat, 2010-12-11 at 01:57 +0800, Matthew Garrett wrote:
> > The reset register was only introduced with version 2 of the FADT, so we
> > should check that the FADT revision before trusting its contents.
> >
> does the current code break anything?
> I'm curious about how you found this bug. :)

No, it just seems to be a sensible sanity check.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andi Kleen: "[PATCH] [54/223] reiserfs: don't acquire lock recursively in reiserfs_acl_chmod"
Previous message: Andi Kleen: "[PATCH] [55/223] staging: rt2870: Add new USB ID for Belkin F6D4050 v1"
In reply to: Zhang Rui: "Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 beforeusing the reset register"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]