RE: [PATCH] [167/223] ACPI: debugfs custom_method open to non-root

[Brown, Len]

> 2.6.35-longterm review patch.  If anyone has any objections, please let me know.

is -longterm something that happens after -stable runs out of gas?
Note that this particular patch applies back to 2.6.33.

thanks,
-Len

> ------------------
> From: Dave Jones <davej@xxxxxxxxxx>
> 
> commit ed3aada1bf34c5a9e98af167f125f8a740fc726a upstream.
> 
> Currently we have:
> 
>   --w--w--w-. 1 root root 0 2010-11-11 14:56 /sys/kernel/debug/acpi/custom_method
> 
> which is just crazy. Change this to --w-------.
> 
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> ---
>  drivers/acpi/debug.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/acpi/debug.c
> ===================================================================
> --- linux.orig/drivers/acpi/debug.c
> +++ linux/drivers/acpi/debug.c
> @@ -258,7 +258,7 @@ static int acpi_debugfs_init(void)
>  	if (!acpi_dir)
>  		goto err;
> 
> -	cm_dentry = debugfs_create_file("custom_method", S_IWUGO,
> +	cm_dentry = debugfs_create_file("custom_method", S_IWUSR,
>  					acpi_dir, NULL, &cm_fops);
>  	if (!cm_dentry)
>  		goto err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/