Re: [PATCH v2] Staging: rt2860: include KERN_* in printk

From: Greg KH
Date: Mon Dec 13 2010 - 13:36:33 EST


On Mon, Dec 13, 2010 at 12:58:44AM +0100, L. Alberto Giménez wrote:
> Fix checkpatch complains.
>
> The change of the DBGPRINT_ERR macro causes the change on the callers.

What change?

>
> Signed-off-by: L. Alberto Giménez <agimenez@xxxxxxxxxxx>
> ---
> drivers/staging/rt2860/chip/rtmp_phy.h | 14 ++++++------
> drivers/staging/rt2860/common/ba_action.c | 6 ++--
> drivers/staging/rt2860/common/cmm_data.c | 2 +-
> drivers/staging/rt2860/common/cmm_mac_pci.c | 10 ++++----
> drivers/staging/rt2860/common/cmm_mac_usb.c | 2 +-
> drivers/staging/rt2860/common/cmm_wpa.c | 22 +++++++-----------
> drivers/staging/rt2860/common/ee_efuse.c | 15 +++++++++---
> drivers/staging/rt2860/common/mlme.c | 13 +++++------
> drivers/staging/rt2860/common/rt_rf.c | 3 +-
> drivers/staging/rt2860/common/rtmp_init.c | 24 ++++++++-----------
> drivers/staging/rt2860/common/rtmp_mcu.c | 4 +-
> drivers/staging/rt2860/common/spectrum.c | 2 +-
> drivers/staging/rt2860/pci_main_dev.c | 2 +-
> drivers/staging/rt2860/rt_linux.c | 21 ++++++++---------
> drivers/staging/rt2860/rt_linux.h | 6 +----
> drivers/staging/rt2860/rt_main_dev.c | 2 +-
> drivers/staging/rt2860/rt_usb.c | 32 +++++++++++++-------------
> drivers/staging/rt2860/sta/assoc.c | 2 +-
> drivers/staging/rt2860/sta/auth.c | 3 +-
> drivers/staging/rt2860/sta/connect.c | 3 +-
> drivers/staging/rt2860/sta/rtmp_data.c | 2 +-
> drivers/staging/rt2860/sta/sync.c | 6 ++--
> drivers/staging/rt2860/usb_main_dev.c | 12 +++++-----
> 23 files changed, 99 insertions(+), 109 deletions(-)

That's a lot of different changes all in one patch. Care to break it up
into a few different patches so it makes more sense?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/