Re: [PATCH 1/2] Staging: vme_ca91cx42: use __dev{init,exit} for->probe/remove

From: Namhyung Kim
Date: Mon Dec 13 2010 - 23:43:56 EST


2010-12-13 (ì), 10:26 -0800, Greg KH:
> On Sun, Dec 12, 2010 at 05:04:27PM +0900, Namhyung Kim wrote:
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> > ---
> > drivers/staging/vme/bridges/vme_ca91cx42.c | 12 +++++++-----
>
> This patch does not apply to the linux-next tree, what did you generate
> it against?
>

Argh.. sorry, it was Linus's tree. Will resend if you want.


> Also, why are you marking these functions, is it really needed? Same
> thing for your 2/2 patch.
>

?? Maybe I don't get what you mean exactly.. They are hotplugging
stuffs, right? So shouldn't they be marked as such?


--
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/