Re: [PATCH 9/9] xen/xen-pciback: Swap over to DEFINE_PCI_DEVICE_TABLE

From: Jan Beulich
Date: Tue Dec 14 2010 - 05:08:34 EST


>>> On 13.12.10 at 19:01, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> drivers/xen/pciback/pci_stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/pciback/pci_stub.c b/drivers/xen/pciback/pci_stub.c
> index c8f6f29..09dd60c 100644
> --- a/drivers/xen/pciback/pci_stub.c
> +++ b/drivers/xen/pciback/pci_stub.c
> @@ -497,7 +497,7 @@ static void pcistub_remove(struct pci_dev *dev)
> }
> }
>
> -static const struct pci_device_id pcistub_ids[] = {
> +DEFINE_PCI_DEVICE_TABLE(pcistub_ids) = {
> {
> .vendor = PCI_ANY_ID,
> .device = PCI_ANY_ID,


You shouldn't drop "static" here.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/