Re: [cpuops cmpxchg V2 5/5] cpuops: Use cmpxchg for xchg to avoidlock semantics

From: H. Peter Anvin
Date: Tue Dec 14 2010 - 12:02:16 EST


On 12/14/2010 08:55 AM, Christoph Lameter wrote:
>
> We do not need to reload the value as pointed out by Eric. It is already in
> the correct register so just rerun the cmpxchg without the load.
>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
>

Is it genuinely faster to do the pre-load mov, or can we drop that too?
My guess would be that yes it is, but if it happens not to be it would
be nice to reduce the code size.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/