Re: [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normalnegative error value return

[J. Bruce Fields]

On Sun, Nov 14, 2010 at 06:08:11PM -0800, Joe Perches wrote:
> And remove unnecessary double semicolon too.
> 
> No effect to code, as test is != 0.

Hm, the error return's actually ignored.  But OK.  Applying to my tree
for 2.6.38 assuming nobody else has picked it up.

--b.

> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>  net/sunrpc/auth_gss/gss_krb5_crypto.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index 75ee993..9576f35 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -137,7 +137,7 @@ arcfour_hmac_md5_usage_to_salt(unsigned int usage, u8 salt[4])
>  		ms_usage = 13;
>  		break;
>  	default:
> -		return EINVAL;;
> +		return -EINVAL;
>  	}
>  	salt[0] = (ms_usage >> 0) & 0xff;
>  	salt[1] = (ms_usage >> 8) & 0xff;
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/