Re: [patch 2/3] add new macros to make percpu readmostly sectioncorrectly align

From: Shaohua Li
Date: Wed Dec 15 2010 - 19:55:16 EST


On Wed, 2010-12-15 at 22:49 +0800, Tejun Heo wrote:
> Hello,
>
> On 12/15/2010 03:08 PM, Tejun Heo wrote:
> >> +#ifdef INTERNODE_CACHE_BYTES
> >> +#define INTERNODE_CACHEALIGNED \
> >> + . = ALIGN(INTERNODE_CACHE_BYTES);
> >> +#else
> >> +#define INTERNODE_CACHEALIGNED
> >> +#endif
> >
> > Yeah, this looks good.
>
> Just one more thing. If you look at various arch linker scripts,
> cache line size is always present. After all, RW_DATA_SECTION() needs
> it. They're different define's or sometimes hardcoded values but it
> would be nice if we can take this chance to unify them and use it for
> this too. Would you be interested in doing that?
might not, sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/