Re: [RFC][PATCH 3/5] sched: Change the ttwu success details

From: Frederic Weisbecker
Date: Thu Dec 16 2010 - 10:36:03 EST


On Thu, Dec 16, 2010 at 04:27:55PM +0100, Peter Zijlstra wrote:
> On Thu, 2010-12-16 at 16:23 +0100, Frederic Weisbecker wrote:
>
> > > - TP_printk("comm=%s pid=%d prio=%d success=%d target_cpu=%03d",
> > > + TP_printk("comm=%s pid=%d prio=%d target_cpu=%03d",
> > > __entry->comm, __entry->pid, __entry->prio,
> > > - __entry->success, __entry->target_cpu)
> > > + __entry->target_cpu)
> >
> > Note we'll need to fix some perf scripts after that. And also perf sched,
> > probably perf timechart and so on...
>
> Do any of those actually use the success parameter? If not, then me
> removing it shouldn't break those tools since they're supposed to parse
> the format stuff and not notice it missing ;-)


Yep, builtin-sched.c and sched-migration.py do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/