Re: [PATCH V7 5/8] ptp: Added a brand new class driver for ptp clocks.

[Arnd Bergmann]

On Thursday 16 December 2010, Richard Cochran wrote:
> This patch adds an infrastructure for hardware clocks that implement
> IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a
> registration method to particular hardware clock drivers. Each clock is
> presented as a standard POSIX clock.
> 
> The ancillary clock features are exposed in two different ways, via
> the sysfs and by a character device.
> 
> Signed-off-by: Richard Cochran <richard.cochran@xxxxxxxxxx>

Looks fine to me, with one tiny comment:

> +
> +/* private globals */
> +
> +extern struct device_attribute ptp_dev_attrs[]; /* see ptp_sysfs.c */

The declaration is in a C file, better move it into a header in order
to make sure the definition matches the declaration.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/