Re: [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init

From: Grant Likely
Date: Thu Dec 16 2010 - 12:27:47 EST


On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:
> Since of_probe_platform_driver(), this SoC-device can be moved from
> __devinit to __init because it is not hotpluggable.
>
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

I really wouldn't bother. You're counting pennies when the kernel
uses upwards of 4 megabytes for .text alone, and I don't like fiddling
with the driver model the way platform_bus_probe() does.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/