Re: [PATCH v5 4/5] msm: hotplug: support cpu hotplug on msm

[Jeff Ohlstein]

Catalin Marinas wrote:
> On 16 December 2010 06:54, Jeff Ohlstein <johlstei@xxxxxxxxxxxxxx> wrote:
> > --- /dev/null
> > +++ b/arch/arm/mach-msm/hotplug.c
> [...]
> > +static inline void platform_do_lowpower(unsigned int cpu)
> > +{
> > +       /* Just enter wfi for now. TODO: Properly shut off the cpu. */
> > +       for (;;) {
> > +               /*
> > +                * here's the WFI
> > +                */
> > +               asm(".word      0xe320f003\n"
> > +                   :
> > +                   :
> > +                   : "memory", "cc");
>
> Is this for an ARMv7 platform? If yes, you could just use the WFI
> instruction directly (and it would also work if compiling the kernel
> to Thumb-2 mode).
>   

I was trying to make the code as similar to the realview code as I
reasonably could. There are several instances of that, we could fix all
of them in one go.

-Jeff

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/