Re: [PATCH] mmc/sdhci: Enable bus-width test for JMicroncontrollers

From: Chris Ball
Date: Thu Dec 16 2010 - 22:58:16 EST


Hi Takashi,

On Thu, Dec 16, 2010 at 05:54:14PM +0100, Takashi Iwai wrote:
>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
>
> This is a patch to be applied after
> "mmc: Test bus-width for old MMC devices (v2)"
>
> and a replacement for the previous "mmc: Enable bus-width tests on
> SDHCI host" patch. Instead of enabling all for sdhci, this one turns
> on the feature only for JMicron, just to be safer.
>
>
> drivers/mmc/host/sdhci-pci.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
> index d2638ff..0dc905b 100644
> --- a/drivers/mmc/host/sdhci-pci.c
> +++ b/drivers/mmc/host/sdhci-pci.c
> @@ -381,6 +381,8 @@ static int jmicron_probe_slot(struct sdhci_pci_slot *slot)
> slot->chip->pdev->device == PCI_DEVICE_ID_JMICRON_JMB388_ESD)
> jmicron_enable_mmc(slot->host, 1);
>
> + slot->host->mmc->caps |= MMC_CAP_BUS_WIDTH_TEST;
> +
> return 0;
> }
>

Thanks, pushed to mmc-next.

(Do others on the list agree that bus-width testing should be
whitelisted per-host like this?)

--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/