Re: [PATCH] writeback: skip balance_dirty_pages() for in-memory fs

From: Minchan Kim
Date: Fri Dec 17 2010 - 10:42:24 EST


On Sat, Dec 18, 2010 at 12:34 AM, Minchan Kim <minchan.kim@xxxxxxxxx> wrote:
> On Fri, Dec 17, 2010 at 8:21 PM, Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:
>> This avoids unnecessary checks and dirty throttling on tmpfs/ramfs.
>>
>> It also prevents
>>
>> [  388.126563] BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
>>
>> in the balance_dirty_pages tracepoint, which will call
>>
>>        dev_name(mapping->backing_dev_info->dev)
>>
>> but shmem_backing_dev_info.dev is NULL.
>>
>> CC: Hugh Dickins <hughd@xxxxxxxxxx>
>> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
>
> Is it a material for -stable?

No. balance_dirty_pages tracepoint is new. :)

>
> --
> Kind regards,
> Minchan Kim
>



--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/