Re: mmotm 2010-12-16-14-56 uploaded (hugetlb)

From: Andrew Morton
Date: Fri Dec 17 2010 - 17:53:58 EST


On Fri, 17 Dec 2010 14:33:16 -0800
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Thu, 16 Dec 2010 14:56:39 -0800 akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>
> > The mm-of-the-moment snapshot 2010-12-16-14-56 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://zen-kernel.org/kernel/mmotm.git
> >
> > It contains the following patches against 2.6.37-rc6:
>
>
> # CONFIG_HUGETLBFS is not set
> CONFIG_HUGETLB_PAGE=y
>
>
> In file included from mmotm-2010-1216-1456/kernel/fork.c:36:
> mmotm-2010-1216-1456/include/linux/hugetlb.h: In function 'hstate_inode':
> mmotm-2010-1216-1456/include/linux/hugetlb.h:255: error: implicit declaration of function 'HUGETLBFS_SB'
>

afacit, CONFIG_HUGETLBFS must be enabled if CONFIG_HUGETLB_PAGE=y, and
thp-config_transparent_hugepage.patch broke that, by permitting
CONFIG_HUGETLBFS=n, CONFIG_HUGETLB_PAGE=y,
CONFIG_TRANSPARENT_HUGEPAGE=y.

I suppose CONFIG_TRANSPARENT_HUGEPAGE could select CONFIG_HUGETLBFS,
but is there a nicer way?


There's lots of stuff in hugetlb.h which is clearly related to
hugetlbfs, but is enabled by CONFIG_HUGETLB_PAGE, so those things seem
to be pretty joined at the hip nowadays.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/