Re: [PATCH] Input: Fix double equality sign in uevent

[Henrik Rydberg]

On Sun, Dec 19, 2010 at 12:04:28AM -0800, Dmitry Torokhov wrote:
> On Sat, Dec 18, 2010 at 08:31:57PM +0100, Henrik Rydberg wrote:
> > Looking at the uevent stream for input devices, all properties
> > are on the form "A=B" except the bitmap values, which are on the
> > form "A==B". Remedied with this patch.
> > 
> > Cc: stable@xxxxxxxxxx
> > Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> > ---
> > Hi Dmitry,
> > 
> > Unless the input bitmap properties should really behave differently,
> > this patch ought to be a candidate for 2.6.37.
> > 
> 
> Hmm, I do not think so because:
> 
> - either nobody uses bitmap variables and then it is not priority
> - users worked around the problem and by applying fix we'd be
>   breaking their setups.
> 
> I think we should apply it but at the beginning of .38 cycle to give us
> a chance to evaluate and maybe revert.
> 
> Does this make sense?

Indeed, since the problem has been around at least since 2007, it makes perfect sense.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/