Re: mmotm 2010-12-16 - breaks mlockall() call

From: Michel Lespinasse
Date: Sun Dec 19 2010 - 20:54:28 EST


On Sat, Dec 18, 2010 at 2:10 AM, <Valdis.Kletnieks@xxxxxx> wrote:
> On Thu, 16 Dec 2010 14:56:39 PST, akpm@xxxxxxxxxxxxxxxxxxxx said:
>> The mm-of-the-moment snapshot 2010-12-16-14-56 has been uploaded to
>>
>>    http://userweb.kernel.org/~akpm/mmotm/
>
> The patch mlock-only-hold-mmap_sem-in-shared-mode-when-faulting-in-pages.patch
> causes this chunk of code from cryptsetup-luks to fail during the initramfs:
>
>        if (mlockall(MCL_CURRENT | MCL_FUTURE)) {
>                        log_err(ctx, _("WARNING!!! Possibly insecure memory. Are you root?\n"));
>                        _memlock_count--;
>                        return 0;
>                }
>
> Bisection fingered this patch, which was added after -rc4-mmotm1202, which
> boots without tripping this log_err() call.  I haven't tried building a
> -rc6-mmotm1216 with this patch reverted, because reverting it causes apply
> errors for subsequent patches.
>
> Ideas?

I had a quick look, but didn't figure out much so far.

Could you send me your initramfs image and .config file so I can
reproduce the issue locally ?

Thanks,

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/