Re: [V2 PATCH] kthread_work: Make lockdep happy

[Yong Zhang]

On Wed, Dec 22, 2010 at 8:39 AM, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote:
> Yong,
>
> I have tested your patch with the following patch on top of yours. ÂI
> find the two patches together acceptable in testing in a machine with
> both a PVR-350 card and a PVR-500 card installed.
>
> Tested-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
> Signed-off-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
>
> Could you please author a [V3 PATCH] adding my changes?

Sure. Will do it.

> Since the
> majority of the change is your work, it should be attributed to you as
> the author.
>
>
> About my additional changes:
>
> I needed the explicit EXPORT_SYMBOL_GPL(__init_kthread_worker),
> otherwise the build would fail, because the ivtv module had an
> unresolved symbol.

Will update.

>
> I added the lockdep class name to make it easier to identify the ivtv
> module's kthread worker's lock class. ÂNow one can actually recognize
> the lock class in lockdep output strings:
>
> Â Â Â Â# cat lockdep | grep itv
> Â Â Â Âffffffffa0483a60 FD: Â Â1 BD: Â Â1 ......: (&itv->irq_worker)->lock

Yeah, I like your idea.

V3 coming soon :)

Thanks,
Yong
-- 
Only stand for myself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/