Re: [PATCH 16/16] ptrace: remove the extra wake_up_process() fromptrace_detach()

From: Tejun Heo
Date: Wed Dec 22 2010 - 05:36:40 EST


On Tue, Dec 21, 2010 at 06:54:39PM +0100, Oleg Nesterov wrote:
> On 12/06, Tejun Heo wrote:
> >
> > --- a/kernel/ptrace.c
> > +++ b/kernel/ptrace.c
> > @@ -391,8 +391,6 @@ int ptrace_detach(struct task_struct *child, unsigned int data)
> > if (child->ptrace) {
> > child->exit_code = data;
> > dead = __ptrace_detach(current, child);
> > - if (!child->exit_state)
> > - wake_up_process(child);
>
> I can only repeat that I obviously like this change ;)
>
> Now that Jan and Roland do not object, perhaps it can be sent as 2/X.
> This is bugfix, after all (like the first patch).

I'll send out the acked ones as a separate patchset so that they can
be merged.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/