[PATCH] USB: DL100B webmail notifier: initialize return value

From: Melchior FRANZ
Date: Wed Dec 22 2010 - 07:55:42 EST


From: Melchior FRANZ <mfranz@xxxxxx>

If case of an unknown usb_device_id->driver_info (which could only
occur if the info got corrupted somewhere outside the usbled driver),
a debug message depended on an uninitialized value. This was harmless,
but ugly, and gets fixed with this patch.

Signed-off-by: Melchior FRANZ <mfranz@xxxxxx>
---

@Greg:
Argh ... sorry about that. The build system didn't warn me, not even
with EXTRA_CFLAGS=-W. And cppcheck ignored the problem as well. This
must be a plot to damage my reputation! :-}

m.



drivers/usb/misc/usbled.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/misc/usbled.c b/drivers/usb/misc/usbled.c
index 1732d9b..1616ad1 100644
--- a/drivers/usb/misc/usbled.c
+++ b/drivers/usb/misc/usbled.c
@@ -45,7 +45,7 @@ struct usb_led {

static void change_color(struct usb_led *led)
{
- int retval;
+ int retval = 0;
unsigned char *buffer;

buffer = kmalloc(8, GFP_KERNEL);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/