Re: [PATCH v2 2/3]mmc: enable runtime PM support of sdhci host controller

From: Pierre Tardy
Date: Wed Dec 22 2010 - 08:27:35 EST


> +int sdhci_runtime_suspend(struct sdhci_host *host)
> +{
> +       int ret = 0;
> +
> +       if (host->vmmc)
> +               ret = regulator_disable(host->vmmc);
Please dont suspend the card's power in the sdhci's suspend function.
This means the card will die.
Think of the wifi idle use case where the wifi is working, but sdio
bus is not used. sdhci will suspend, but wifi card wont.
manipulation of the host->vmmc must be done in set_ios() (I will send
the patch later in the week...)

Regards,
--
Pierre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/