Re: [5/7, v9] NUMA Hotplug Emulator: Support cpu probe/release inx86_64

From: Andrew Morton
Date: Thu Dec 23 2010 - 00:35:32 EST


On Thu, 23 Dec 2010 10:24:28 +0800 Shaohui Zheng <shaohui.zheng@xxxxxxxxxxxxxxx> wrote:

> >
> > Why *does* it check `count' and then not use it?
> >
>
> it is a tricky thing. When I debug it under a Virtual Machine, If I do a cpu
> probe via sysfs cpu/probe interface, The function arch_cpu_probe will be called
> __three__ times, but only one call is valid, so I add a check on `count` to
> ignore the invalid calls.

hm, why does it get called three times? Is that something which
can/should be fixed in callers rather than in the callee?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/