Re: [PATCH 2/2]block cfq: don't use atomic_t for cfq_group

From: Jeff Moyer
Date: Thu Dec 23 2010 - 10:27:43 EST


Shaohua Li <shaohua.li@xxxxxxxxx> writes:

> cfq_group->ref is used with queue_lock hold, the only exception is
> cfq_set_request, which looks like a bug to me, so ref doesn't need
> to be an atomic and atomic operation is slower.
>
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/