Re: MFD cell structure and sharing of resources

From: Samuel Ortiz
Date: Fri Dec 24 2010 - 05:46:28 EST


Hi Daniel,

On Thu, Dec 16, 2010 at 03:38:52PM +0000, Daniel Drake wrote:
> Hi Samuel,
>
> Thanks for your valuable input here!
Thanks for your patience. I've been swamped at work with other projects, sorry
for the delay.

> I have one solution in mind but I'm not sure if it goes beyond your
> definition of what a mfd cell should be:
>
> cs5535-mfd creates and registers a MFD cell specifically for
> olpc-xo1-pm if it finds itself running on an XO laptop. The cell has
> the 2 resources that are needed by that driver, and has name
> "olpc-xo1-pm". Therefore our sysfs paths start with:
> /sys/devices/pci0000:00/0000:00:0f.0/olpc-xo1-pm/
That is stretching things a bit, but I'd be ok with that solution.
In theory, you wouldn't even need to check if you're on an XO laptop, except
for saving a few bytes at runtime.

One more thing: What about my proposal of defining IO routines from the MFD
driver, and using those from your subdevices driver ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/