Re: [PATCH] 3c59x: Don't assign when a comparison is intended
From: Wolfram Sang
Date: Sat Dec 25 2010 - 17:17:57 EST
On Sat, Dec 25, 2010 at 09:50:56PM +0100, richard -rw- weinberger wrote:
> On Sat, Dec 25, 2010 at 9:30 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> > Hi,
> >
> > In drivers/net/3c59x.c::vortex_probe1() we have this code:
> >
> > if (gendev) {
> > if ((pdev = DEVICE_PCI(gendev))) {
> > print_name = pci_name(pdev);
> > }
> >
> > if ((edev = DEVICE_EISA(gendev))) {
> > print_name = dev_name(&edev->dev);
> > }
> > }
> >
> > I believe these assignments were intended to be comparisons.
> > If I'm correct, then here's a patch to fix that up.
>
> I don't think so. Look at the extra brackets.
>
> The code can also written as:
>
> pdev = DEVICE_PCI(gendev);
> if(pdev)
> print_name = pci_name(pdev);
... which looks much better and could be worth a patch as well.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature