Re: [PATCH] befs: Don't pass huge structs by value.

[Will Dyson]

On Sat, Dec 25, 2010 at 2:27 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> Hi there,
>
> 'struct befs_disk_data_stream' is huge (~144 bytes) and it's being passed
> by value in fs/befs/endian.h::cpu_to_fsrun().
>
> It seems to me that it would be better to pass a pointer, no?
> This patch changes the function to take a pointer to the large struct.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Seems very reasonable to me. Unfortunately, I have no longer have any
befs filesystems to test on either.

-- 
Will Dyson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/