Re: [PATCH v3] rtc-cmos: fix suspend/resume

From: Daniel Drake
Date: Wed Dec 29 2010 - 13:34:12 EST


On 22 December 2010 22:19, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> It's unclear what the user-visible effects of this bug were.  Machine
> fails to suspend?  RTC loses its brains on resume?  Something else?
>
> That's really important information for a bugfix's changelog.  Please
> never omit it.

Sorry about that.
After looking in more detail, I agree with Paul. This bug only affects
setups where no PNP RTC is available, or where CONFIG_PNP is disabled.
It also affects OLPC's coming-soon addition of an XO-specific RTC
driver.

So, a clear and simple fix, but not a wide-reaching bug in the first place.
2.6.38 would be fine, no real need for -stable backporting IMO.

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/