Re: [PATCH 15/16] x86: Unify node_to_cpumask_map handling between32 and 64bit

[Tejun Heo]

Hello,

On Thu, Dec 30, 2010 at 10:40:33AM -0800, David Rientjes wrote:
> On Thu, 30 Dec 2010, Tejun Heo wrote:
> 
> > > Sigh, the new NUMA emulation thing is 64bit only. :-( I'll see if it
> > > can be applied to 32bit too.  BTW, how does this interact with the
> > > Shaohui's patchset.  Isn't that about NUMA emulation too?  Are these
> > > the same patches?
> 
> Shaohui's patchset is for node hotplug emulation, not for NUMA emulation 
> which has existed for x86_64 for at least over four years.

I see.  Yeah, I should have actually read the patchset before talking
about it.

> I agree that unification is in our best interest but the patches as they 
> sit in x86/numa right now actually fix real bugs when using numa=fake on 
> the command line and adding i386 NUMA emulation is an additional feature 

I'm not really arguing against you and as said before the patches were
fine given the current state of the code, but I still want to point
out that it's through these mostly innocent series of changes which
build upon existing complications which eventually lead to
unsustainable pile of mess.  No one is particularly wrong but then
again none does what really needs to be done.

> (and the unification that can be done in the meantime would only be the 
> actual apicid-to-node and pxm-to-node mappings after it is exported from 
> amd and acpi specific functions), so I'd prefer to handle cleanups as 
> incremental patches on top of those.

The problem is that those "incremental" patches often don't happen
once the itch is gone while the immediate fixes/improvements aggravate
existing complications.  If you were/are planning to clean it up, I
have nothing to whine about.  :-)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/