Re: [PATCH] taskstats: Use better ifdef for alignment

From: Dan Carpenter
Date: Sat Jan 01 2011 - 11:52:09 EST


On Sat, Jan 01, 2011 at 05:19:46PM +0100, Florian Mickler wrote:
> Is there already a patch available or integrated into iotop which
> fixes this? I'd think that if the kernel could wait on fixed iotop's to
> be distributed it would be easier to sell the breakage on bugzilla &
> co...
>

The story is that 4be2c95d1f "taskstats: pad taskstats netlink response
for aligment issues on ia64" broke iotop on 64 bit processors (32 bit
was unaffected). This patch fixes it for x86-64 and powerpc-64.

On the other 64 bit processors iotop works but instead you get a message
in dmesg:
kernel unaligned access to 0xe000023879dca9bc, ip=0xa000000100133d10

So on those arches you were already getting posts to bugzilla etc. Now
those people can upgrade the kernel and download iotop version 0.4.2 or
higher.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/