Summary of REGRESSIONS which are being ignored?! (Re: Summary ofthe pending patches up to Dec, 31 (26 patches))

From: Andy Walls
Date: Sun Jan 02 2011 - 15:28:43 EST


On Fri, 2010-12-31 at 10:41 -0200, Mauro Carvalho Chehab wrote:
> Dear Developers,
>
> I'm enclosing the current list of patches that I have on my queue. I did
> an effort to apply a large amount of patches during the past two weeks, in
> order to be ready for the 2.6.38 merge window, expected to be after
> the end year's holiday.
>
> I lost about one month of emails from the period between Nov-Dec, so
> I may have lost a pull request, or some patch comments. I had to fully
> rely on patchwork for the patches sent during that period.

Hi Mauro,

I don't see this patch on it's way upstream:

https://patchwork.kernel.org/patch/376612/ (Sent on 5 Dec 2010)
http://www.spinics.net/lists/linux-media/msg26649.html (Resent on 19 Dec 2010)

It fixes a regression in IR and Analog video for cx23885 based cards and
an intermittent analog video regression in ivtv based cards in 2.6.36
and soon in 2.6.37.

I don't see it in the media_tree staging/for_v2.6.38 nor
staging/for_2.6.37-rc1 nor master:
http://git.linuxtv.org/media_tree.git?a=history;f=drivers/media/video/cx25840/cx25840-core.c;h=dfb198d0415bc200b0152c1be105d722261653c5;hb=staging/for_v2.6.38
http://git.linuxtv.org/media_tree.git?a=history;f=drivers/media/video/cx25840/cx25840-core.c;h=dfb198d0415bc200b0152c1be105d722261653c5;hb=master
http://git.linuxtv.org/media_tree.git?a=history;f=drivers/media/video/cx25840/cx25840-core.c;h=dfb198d0415bc200b0152c1be105d722261653c5;hb=staging/for_v2.6.37-rc1

I don't see it at a very recent linux-next:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=history;f=drivers/media/video/cx25840/cx25840-core.c;h=dfb198d0415bc200b0152c1be105d722261653c5;hb=bfa221f25c0ec816f725c3a145bda4ee65a277ff

I don't see it at your kernel.org linux-next tree:
http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-next.git;a=history;f=drivers/media/video/cx25840/cx25840-core.c;h=dfb198d0415bc200b0152c1be105d722261653c5;hb=refs/heads/master

Am I missing something?

I cannot get this *REGRESSION*, which I did not introduce, fixed in
stable tree(s) until it is upstream.


Also this following commit causes a very bad analog audio *REGRESSION*,
which is now shipping in major distirbutions:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcb9757333df37cf4a7feccef7ef6f5300643864

I emailed the LMML, you, and the author, as soon as I verified the root
cause on 31 Dec, and haven't heard from from anyone:

http://www.spinics.net/lists/linux-media/msg27261.html

Please revert it before the merge window closes.

<rant>
I have no time to make improvements that I want to make, much less waste
my *VOLUNTEER* time on *REGRESSIONS* that *I DID NOT INTRODUCE*.

It bothers me enough, that as a volunteer, I have to clean up other
people's untested cr*pware. AND, that as the lucky individual who finds
the bugs, I have to do additional work to get fixes back into stable
kernels.

Watching my requests for regressions to be fixed be ignored, as merge
windows go by without the fixes going forward so that even more users
and kernel versions are affected, makes me wonder why I do this anymore.

Anyone want to be ivtv and cx18 maintainer?
</rant>


> Kernel 2.6.38 will be a nice Kernel for us, as it will contain some
> very interesting things:
> - The removal of BKL (in fact, .37 will have that also, but
> we have some BKL cleanups already for .38, and I suspect that we'll
> have some bug fixes for the changes during the .38 rc period);
> - The removal of V4L1 API. We're trying to remove it for a
> very long time. V4L2 API is here since 2002. That means that we took
> 8 years to remove the legacy API.
> - The merge between lirc_i2c and ir-kbd-i2c. The LIRC i2c driver
> is also very old, and there were several IR key parsers implemented
> on both. The missing things were migrated into ir-kbd-i2c and some
> board-specific get key parsers into their respective boards.
>
> Due to that, we have enough reasons to celebrate the end of this year
> and the arrival of the next year.

I do not share your optimism. Regressions that affect the analog video
capture, for the userbase I deal with, have been introduced due to lack
of review and testing. It appears to me, that these regessions are
going to be in yet another kernel version, 2.6.37, and the gates for
getting the known fixes back into stable kernels will still be left
unsatisfied.


> Cheers!

I, nor PVR-150 and HVR-1250 users, have much to cheer about.


Regards,
Andy


> I wish you all the best for the coming year!
>
> P.S.:
>
> 1) I explicitly c/c the developers or the ones waiting for an analysis.
> If you're a developer and were c/c, please comment on the listed
> patches.
> 2) I removed the Videobuf2 patches from the list. I expect to be
> analyzing and testing them during the next week.
>
> == Need more tests/acks from DVB users ==
>
> Aug, 7 2010: Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function http://patchwork.kernel.org/patch/118147 Marko Ristola <marko.ristola@xxxxxxxxxxx>
>
> ************************************************************************
> * I want to see people testing the above patch, as it seems to improve *
> * DVB performance by avoiding data copy. *
> ************************************************************************
>
> == mantis patches - Waiting for Manu Abraham <abraham.manu@xxxxxxxxx> ==
>
> Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files http://patchwork.kernel.org/patch/107062 BjÃÂrn Mork <bjorn@xxxxxxx>
> Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis) http://patchwork.kernel.org/patch/112708 Niklas Claesson <nicke.claesson@xxxxxxxxx>
> Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt http://patchwork.kernel.org/patch/118173 Marko Ristola <marko.ristola@xxxxxxxxxxx>
> Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod http://patchwork.kernel.org/patch/244201 Tuxoholic <tuxoholic@xxxxxxxxxx>
>
> == for Adams.Xu <adams.xu@xxxxxxxxxxxxx> and Manu Abraham <abraham.manu@xxxxxxxxx> review ==
>
> Jun,11 2010: stb0899: Removed an extra byte sent at init on DiSEqC bus http://patchwork.kernel.org/patch/105621 Florent AUDEBERT <florent.audebert@xxxxxxxxxx>
>
> == Waiting for Steven Toth <stoth@xxxxxxxxxxxxxx> review ==
>
> Nov,24 2010: [media] saa7164: poll mask set incorrectly http://patchwork.kernel.org/patch/351711 Dan Carpenter <error27@xxxxxxxxx>
>
> == Soc_camera waiting for Guennadi Liakhovetski <g.liakhovetski@xxxxxx> review ==
>
> Aug, 3 2010: [04/11] mt9m111: added new bit offset defines http://patchwork.kernel.org/patch/116721 Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> Aug, 3 2010: [08/11] mt9m111: added reg_mask function http://patchwork.kernel.org/patch/116722 Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern http://patchwork.kernel.org/patch/116730 Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> Oct,25 2010: [v3] mt9m111: rewrite set_pixfmt http://patchwork.kernel.org/patch/266822 Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> Nov,17 2010: v4l: list entries no need to check http://patchwork.kernel.org/patch/332611 Figo.zhang <figo1802@xxxxxxxxx>
> Dec, 2 2010: [v3] soc_camera: Add the ability to bind regulators to soc_camedra dev http://patchwork.kernel.org/patch/373691 Alberto Panizzo <maramaopercheseimorto@xxxxxxxxx>
> Dec, 2 2010: [v2] V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV2640 http://patchwork.kernel.org/patch/374771 Alberto Panizzo <maramaopercheseimorto@xxxxxxxxx>
> Dec, 5 2010: [1/2] OMAP1: allow reserving memory for camera http://patchwork.kernel.org/patch/381601 Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
> Dec, 5 2010: [2/2] OMAP1: Amstrad Delta: reserve memory for camera http://patchwork.kernel.org/patch/381621 Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
>
> Guennadi,
> Probably, several of those patches are obsolete and you already pointed it to me.
> but I probably missed your comments, due to my email issues.
>
> == waiting for Hendrik Skarpeid <skarp@xxxxxxxxx> tests ==
>
> Oct,23 2010: DM1105: could not attach frontend 195d:1105 http://patchwork.kernel.org/patch/279091 Igor M. Liplianin <liplianin@xxxxx>
>
> == Waiting for Patrick Boettcher <pboettcher@xxxxxxxxx> review ==
>
> May,25 2010: Adding support to the Geniatech/MyGica SBTVD Stick S870 remote control http://patchwork.kernel.org/patch/102314 HernÃn Ordiales <h.ordiales@xxxxxxxxx>
> Jul,14 2010: [1/4] drivers/media/dvb: Remove dead Configs http://patchwork.kernel.org/patch/111972 Christian Dietrich <qy03fugy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Jul,14 2010: [2/4] drivers/media/dvb: Remove undead configs http://patchwork.kernel.org/patch/111973 Christian Dietrich <qy03fugy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> == waiting for videobuf2 ==
>
> Mar,17 2010: [2/2] V4L/DVB: buf-dma-sg.c: support non-pageable user-allocated memor http://patchwork.kernel.org/patch/97263 Arnout Vandecappelle <arnout@xxxxxxx>
> Jul,27 2010: videobuf_dma_sg: a new implementation for mmap http://patchwork.kernel.org/patch/114520 Figo.zhang <figo1802@xxxxxxxxx>
> Jul,28 2010: [v2] videobuf_dma_sg: a new implementation for mmap http://patchwork.kernel.org/patch/114760 Figo.zhang <figo1802@xxxxxxxxx>
> Jul,30 2010: [v2] Resend:videobuf_dma_sg: a new implementation for mmap http://patchwork.kernel.org/patch/115348 Figo.zhang <figo1802@xxxxxxxxx>
>
> The above patches will likely be obsolete after videobuf2 merge. We need to double-check
> if the needed functionality is provided on videobuf2.
>
> == Waiting for Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> fixes on Docbook ==
>
> Oct,23 2010: [RFC, PATCHv3] DocBook: Add rules to auto-generate some media docbooks http://patchwork.kernel.org/patch/279201 Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> == Waiting for a Kworld UB430-AF to test and report back to Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> ==
>
> Nov, 8 2010: [RFC] cx231xx: Add support for Kworld UB430 AF http://patchwork.kernel.org/patch/308712 Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
>
> Number of pending patches per reviewer:
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> : 9
> LinuxTV community : 5
> Manu Abraham <abraham.manu@xxxxxxxxx> : 4
> Patrick Boettcher <pboettcher@xxxxxxxxxxxxxx> : 3
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> : 2
> Adams Xu <adams.xu@xxxxxxxxxxxxx> : 1
> Hendrik Skarpeid <skarp@xxxxxxxxx> : 1
> Steven Toth <stoth@xxxxxxxxxxxxxx> : 1
>
> Cheers,
> Mauro
>
> ---
>
> If you discover any patch submitted via email that weren't caught by
> kernel.patchwork.org, this means that the patch got mangled by your emailer.
> The more likely cause is that the emailer converted tabs into spaces or broke
> long lines.
>
> If you're using Thunderbird, the solution is to install Asalted Patches
> extension, available at:
> https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/
> Other emailers will need you to disable the wrapping long lines feature.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/