Should we be using unlikely() around tests of GFP_ZERO?

From: Theodore Ts'o
Date: Sun Jan 02 2011 - 21:50:18 EST

Given the patches being busily submitted by trivial patch submitters to
make use kmem_cache_zalloc(), et. al, I believe we should remove the
unlikely() tests around the (gfp_flags & __GFP_ZERO) tests, such as:

- if (unlikely((flags & __GFP_ZERO) && objp))
+ if ((flags & __GFP_ZERO) && objp)
memset(objp, 0, obj_size(cachep));

Agreed? If so, I'll send a patch...

- Ted
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at