Re: [PATCH UPDATED] workqueue: relax lockdep annotation onflush_work()

From: Peter Zijlstra
Date: Mon Jan 03 2011 - 10:29:00 EST


On Mon, 2011-01-03 at 16:20 +0100, Tejun Heo wrote:
> On Mon, Jan 03, 2011 at 04:14:45PM +0100, Peter Zijlstra wrote:
> > > Hmmm? The code applies the most strict contraints. If the workqueue
> > > has a rescuer, flushing another work from the workqueue will always
> > > trigger lockdep warning. The rule is relaxed only for workqueues
> > > which aren't used for memory reclaiming && support parallel execution.
> >
> > Ah, ok. I read it like: if the current thread is a rescue thread.
>
> Ah, I see. Rafael, can you please verify the updated version is okay
> too (it should be but just in case)? Peter, shall I route this
> through workqueue tree with your ack?

That's fine with me, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/